Repository navigation
test: cover DocsProvider, MobileHeader and SidebarFooter behavior - #259
Merged
Merged
Conversation
Adds a behavior suite for the docs chrome state layer and its two small driver widgets: localStorage-backed banner dismissal and read-back, menu/sidebar toggles, nav-collapse set, the useDocsMenu outside-provider guard, mobile breadcrumb derivation and dismiss-then-toggle wiring, and the theme toggle in both SidebarFooter variants including the isMobile collapse-button suppression and server-rendered pre-mount placeholders. DocsProvider 85.7 -> 100% lines, MobileSidebarToggle 86.7 -> 100%, SidebarFooter 86.7 -> 100% (functions 50 -> 100%). Closes #258 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
src/__tests__/DocsProvider.behavior.test.tsx(18 tests) covering the docs chrome state layer and the two widgets that drive it:bannerDismissedseeded fromlocalStorage(and non-'true'values ignored),dismissBannerpersists while the raw setter does not,toggleMenu/toggleSidebar/setters,toggleNavCollapsedadd/remove without mutating the previous set,navInitializedref, and theuseDocsMenuoutside-provider error./docs/introduction, kebab/snake title-casing, non-/docs/fallback; clicking dismisses the banner and callsonToggleSidebar.setThemecalls in full and slim variants,isMobilehides the collapse button, and server-rendered pre-mount placeholders (viarenderToStaticMarkup, where the mount effect never runs).Coverage at
main@7227ce4→ this branch (npx vitest run --coverage):DocsProvider.tsxMobileSidebarToggle.tsxSidebarFooter.tsxTest-only change; no production code or changelog fragment (per
changelog.d/README.md, test-only changes need none).eslint,prettier --check, andtsc --noEmitare clean.Closes #258
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88